Replace fgrep with grep -F to avoid a warning#207
Merged
marmarek merged 1 commit intoQubesOS:mainfrom Feb 6, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
=======================================
Coverage 72.63% 72.63%
=======================================
Files 10 10
Lines 1162 1162
=======================================
Hits 844 844
Misses 318 318 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marmarek
approved these changes
Feb 6, 2026
Member
marmarek
left a comment
marmarek
left a comment
There was a problem hiding this comment.
The change itself is okay, but it seems there is still fgrep call somewhere else - the warning is shown during grub2-mkconfig call.
Contributor
Author
|
I think you are right and the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today, I updated the dom0 kernel of my Qubes 4.3 system and saw a bunch of "warning: fgrep is obsolescent; using grep -F" messages. This change (if backported) should stop those messages, FWIW. Untested but hopefully obviously correct.